fix(cmd): read --date/--from/--to from cobra flags instead of viper#34
Merged
omarshahine merged 1 commit intosteipete:mainfrom Apr 16, 2026
Merged
Conversation
viper.BindPFlag with generic names like "date", "from", "to" registers them globally, so flags from different commands stomp on each other. Read these values directly from cmd.Flags() and remove the stale viper bindings. Closes steipete#13 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
omarshahine
force-pushed
the
fix/sleep-flag-parsing
branch
from
b21d78b to
7c2d6cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sleep day --date 2026-02-14ignores the flag and queries today's date instead. Same root cause as #20 (fixed in #31):viper.BindPFlagwith generic key names like"date","from","to"registers them globally, so flags from different commands collide.Fix: Read
--date,--from,--todirectly fromcmd.Flags()and remove the staleviper.BindPFlagcalls.Closes #13
Changes
internal/cmd/sleep.go--datefromcmd.Flags(), remove viper bindinginternal/cmd/sleep_range.go--from/--tofromcmd.Flags(), remove viper bindingsTest plan
eightctl sleep day --date 2026-04-10queries April 10, not todayeightctl sleep day(no flag) defaults to todayeightctl sleep range --from 2026-04-10 --to 2026-04-15passes both dates correctlygo test ./...passes🤖 Generated with Claude Code