Fix OAuth credentials and gzip response handling#9
Closed
stirman wants to merge 1 commit intosteipete:mainfrom
Closed
Fix OAuth credentials and gzip response handling#9stirman wants to merge 1 commit intosteipete:mainfrom
stirman wants to merge 1 commit intosteipete:mainfrom
Conversation
1. authTokenEndpoint() was hardcoding 'sleep-client' and empty secret instead of using c.ClientID and c.ClientSecret from config/defaults. 2. API responses come gzip-compressed but weren't being decompressed, causing 'invalid character' JSON parse errors.
Collaborator
|
Thanks for identifying and fixing the OAuth credentials and gzip issues, @stirman! Your PR was one of the first to catch these bugs. I've consolidated the fixes from multiple PRs into #24, which now covers OAuth form-encoding, gzip handling, bounded retries, and headless keyring support. Closing this in favor of that combined fix. Appreciate the contribution — we'll get this released soon! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
authTokenEndpoint()hardcodesclient_id: 'sleep-client'andclient_secret: ''instead of usingc.ClientIDandc.ClientSecretinvalid character '\x1f')Fix
Content-Encoding: gzipheader and decompress before JSON decodeTesting
Tested successfully with Eight Sleep Pod - status command now works.