fix: handle --youtube apify when HTML fetch fails#64
Open
entropyy0 wants to merge 1 commit intosteipete:mainfrom
Open
fix: handle --youtube apify when HTML fetch fails#64entropyy0 wants to merge 1 commit intosteipete:mainfrom
entropyy0 wants to merge 1 commit intosteipete:mainfrom
Conversation
When using --youtube apify, the Apify provider was never attempted if the initial HTML fetch failed or returned empty content. The early `if (!html) return` exit on line 87 short-circuited the entire transcript flow before Apify was reached, even though Apify doesn't need HTML at all. Move explicit apify mode handling before the HTML check so it runs regardless of HTML availability. Closes steipete#51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51
Summary
When using
--youtube apify, the Apify provider was never attempted if the initial HTML fetch failed. Theif (!html) returnearly exit short-circuited the entire transcript flow before Apify was reached — even though Apify doesn't need HTML.Fix
Move explicit apify mode handling before the HTML check so it runs regardless of HTML availability.
Changes
youtube.ts: Handlemode === 'apify'before the!htmlguard, calling Apify directlyAll 1122 tests pass. Build clean.
AI-assisted (Claude via Clawdbot), fully tested.