Adds zed_scalefac to the output netcdf file. #109
Open
daringli wants to merge 3 commits intostellaGK:masterfrom
Open
Adds zed_scalefac to the output netcdf file. #109daringli wants to merge 3 commits intostellaGK:masterfrom
daringli wants to merge 3 commits intostellaGK:masterfrom
Conversation
added 3 commits
May 10, 2023 23:57
…zeta in the stella.geometry file from zed, allowing geometry files to be fully reconstructed from the stella output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zed_scalefac lets us calculate zeta (as defined in the stella.geometry file) from zed, allowing geometry files to be fully reconstructed from the stella netcdf output. Zeta is useful when we want to use a geometric quantity (such as gbdrift) from a different geometry file or stella simulation, as it lets us potentially interpolate to the zeta grid of the new simulation.
Being able to do this construction from the output netcdf file is more precise than using the plaintext .geometry file, as the plaintext .geometry file only saves these quantities with a few digits precision.