Remove explicit CMake Dependency on HDF5#233
Open
valentin-seitz wants to merge 1 commit intostellaGK:masterfrom
Open
Remove explicit CMake Dependency on HDF5#233valentin-seitz wants to merge 1 commit intostellaGK:masterfrom
valentin-seitz wants to merge 1 commit intostellaGK:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR removes the not-needed explicit dependency on HDF5 in the CMake system.
The NetCDF installation normally depends on this, but CMake will discover this automagically through the installed CMake files provided by the NetCDF installation.
The
enable_language(c)is still needed as for some reason the NetCDF installed in the GitHub Mac runners depends on HDF5, which internally needs Threads support, which needs a system language to be enabled...I guarded it behind the NetCDF support to only enable it if really needed.
If you require any changes let me know :)