-
Notifications
You must be signed in to change notification settings - Fork 43
[DRAFT] Update testnet reset script #1757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
422f479 to
4b125da
Compare
scripts/testnet_reset.sh
Outdated
| log_warning "Failed to create Anchor USDC trustline for $account_var" | ||
| fi | ||
|
|
||
| if stellar tx new change-trust \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious. Do all these test accounts need a trustline to Circle USDC? I thought only the distribution account would need it, like we do for SRT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you're right. Fixed.
JiahuiWho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
The PR looks fine to me overall. I don't see the script where we check the circle USDC balance though. (here) Is it no longer needed in our tests? |
|
Can we add a GH action to run the testnet reset? |
|
|
||
| # USDC issuer | ||
| USDC_ISSUER_SECRET= | ||
| USDC_ISSUER_PUBLIC= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .env should not have PUBLIC keys. They can be generated from the secret.
b0811f9 to
4402839
Compare
Description
Updates
testnet_reset.sh.Context
It previously only deployed the contracts.
Testing
Documentation
N/A
Known limitations
N/A