Conversation
|
Size Change: 0 B Total Size: 3.52 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Pull request overview
Regenerates the generated TypeScript XDR declaration files to reflect updated dts-xdr behavior for integer-discriminated unions, improving TypeScript’s ability to type-check union construction and simplifying several duplicated union return types.
Changes:
- Add constructor overloads for integer-discriminated XDR union classes and remove static numeric factory methods.
- Deduplicate/normalize several
value()return types (e.g., removing repeated union members). - Update
CHANGELOG.mdto document the type-generation change (and a small wording tweak).
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
types/next.d.ts |
Regenerated XDR typings: int-discriminated unions now have constructors; removes static numeric factories; cleans up duplicated unions/returns. |
types/curr.d.ts |
Same regeneration updates as types/next.d.ts, plus a few array type normalizations (e.g., Array<T> → T[]). |
CHANGELOG.md |
Adds an Unreleased “Fixed” entry describing the regenerated XDR union typing change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
quietbits
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The XDR type declarations were regenerated to incorporate changes made in dts-xdr for integer-discriminated unions. This change involved adding constructor type declarations to the integer-discriminated union classes so the Typescript compiler recognizes that this is possible.
What
types/curr.d.tsandtypes/next.d.tsnow include constructors for integer-discriminated unionsvalue()method for some union classes