Merged
Conversation
5 tasks
|
Size Change: -13 B (0%) Total Size: 3.6 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Soroban Contract API to be more TypeScript/ESM-friendly and migrates its unit tests to Vitest, along with updating generated type validation output.
Changes:
- Update
src/contract.tsto use ESM-style.jsimport specifiers and add TypeScript typings. - Replace the Mocha
contract_test.jswith a Vitest TypeScript test suitecontract.test.ts. - Add generated
type_validation/contract.d.tsfor theContractclass.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/contract.ts |
Switch imports to .js specifiers and add TS types for constructor/state and call() return type. |
test/unit/contract_test.js |
Removes the legacy Mocha unit tests for Contract. |
test/unit/contract.test.ts |
Adds Vitest-based TypeScript tests for Contract behavior and XDR outputs. |
type_validation/contract.d.ts |
Adds generated declaration output for type-validation of the Contract API. |
types/curr.d.ts |
Changes the Operation import path used by the generated curr XDR typings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
quietbits
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.