Migrated fee_bump_transaction.js file to TS#925
Migrated fee_bump_transaction.js file to TS#925quietbits merged 1 commit intotypescript-migrationfrom
fee_bump_transaction.js file to TS#925Conversation
|
Size Change: -54 B (0%) Total Size: 3.61 MB
|
There was a problem hiding this comment.
Pull request overview
This PR migrates src/fee_bump_transaction.js to TypeScript (src/fee_bump_transaction.ts), adding type annotations, updating import extensions to .js (as required for ESM compatibility), and adding proper override keywords required by noImplicitOverride. It also includes the auto-generated type_validation/fee_bump_transaction.d.ts declaration file, consistent with how other migrated files are handled. The test migration for this file is deferred to a separate PR (#923) because TransactionBuilder (a dependency) is not yet migrated.
Changes:
- Updated imports to use
.jsextensions for ESM compatibility - Added TypeScript type annotations to the class, constructor, fields, and method signatures; replaced incorrect
new xdr.Union.arm(...)calls with the correct static factory call patternxdr.Union.arm(...) - Added auto-generated
type_validation/fee_bump_transaction.d.tsdeclaration file
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/fee_bump_transaction.ts |
TypeScript migration: type annotations, .js import extensions, override keywords, type assertions, and fixed XDR union factory call style |
type_validation/fee_bump_transaction.d.ts |
Auto-generated declaration file from tsc compilation, reflecting the typed source |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
TransactionBuilderis needed for the tests, so they will be migrated in a separate PR: #923