Skip to content

Migrated fee_bump_transaction.js file to TS#925

Merged
quietbits merged 1 commit intotypescript-migrationfrom
tsm-fee-bump-transaction
Mar 11, 2026
Merged

Migrated fee_bump_transaction.js file to TS#925
quietbits merged 1 commit intotypescript-migrationfrom
tsm-fee-bump-transaction

Conversation

@quietbits
Copy link
Contributor

TransactionBuilder is needed for the tests, so they will be migrated in a separate PR: #923

@quietbits quietbits linked an issue Mar 10, 2026 that may be closed by this pull request
5 tasks
@github-actions
Copy link

Size Change: -54 B (0%)

Total Size: 3.61 MB

Filename Size Change
dist/stellar-base.js 2.66 MB -47 B (0%)
dist/stellar-base.min.js 948 kB -7 B (0%)

compressed-size-action

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates src/fee_bump_transaction.js to TypeScript (src/fee_bump_transaction.ts), adding type annotations, updating import extensions to .js (as required for ESM compatibility), and adding proper override keywords required by noImplicitOverride. It also includes the auto-generated type_validation/fee_bump_transaction.d.ts declaration file, consistent with how other migrated files are handled. The test migration for this file is deferred to a separate PR (#923) because TransactionBuilder (a dependency) is not yet migrated.

Changes:

  • Updated imports to use .js extensions for ESM compatibility
  • Added TypeScript type annotations to the class, constructor, fields, and method signatures; replaced incorrect new xdr.Union.arm(...) calls with the correct static factory call pattern xdr.Union.arm(...)
  • Added auto-generated type_validation/fee_bump_transaction.d.ts declaration file

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
src/fee_bump_transaction.ts TypeScript migration: type annotations, .js import extensions, override keywords, type assertions, and fixed XDR union factory call style
type_validation/fee_bump_transaction.d.ts Auto-generated declaration file from tsc compilation, reflecting the typed source

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@quietbits quietbits requested a review from Ryang-21 March 10, 2026 18:41
@quietbits quietbits merged commit 16c5e5e into typescript-migration Mar 11, 2026
10 checks passed
@quietbits quietbits deleted the tsm-fee-bump-transaction branch March 11, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate fee_bump_transaction.js file to TS

3 participants