Replace monaco editor's useMonaco hook with its loader#1941
Merged
jeesunikim merged 5 commits intomainfrom Mar 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Next.js dev unhandled promise rejection triggered by @monaco-editor/react loader cancellation under React StrictMode by replacing useMonaco() usage with a manual loader.init() flow.
Changes:
- Remove
useMonaco()usage and gate rendering on a localisReadystate. - Initialize Monaco via
loader.init()and attach a.catch()to prevent unhandled rejections. - Add an optimization to skip async init when Monaco is already loaded.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Preview is available here: |
quietbits
approved these changes
Mar 10, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
|
Preview is available here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I kept seeing nextjs error whenever the page has Monaco Editor. Claude found that
This PR fixes nextjs error in dev setup.