Skip to content

Remove hardcoded node afinity labels in v1 missions #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jayz22 merged 2 commits into from
Nov 26, 2025
Merged

Remove hardcoded node afinity labels in v1 missions #345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ffaee8
Remove hardcoded node selector
jayz22 Nov 26, 2025
35097c6
fixup! Remove hardcoded node selector
jayz22 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/FSLibrary/StellarKubeSpecs.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ let evenTopologyConstraints : V1TopologySpreadConstraint array =
[| V1TopologySpreadConstraint(
maxSkew = 1,
topologyKey = "kubernetes.io/hostname",
whenUnsatisfiable = "DoNotSchedule",
whenUnsatisfiable = "ScheduleAnyway",
labelSelector = V1LabelSelector(matchLabels = CfgVal.labels)
) |]

Expand Down Expand Up @@ -414,18 +414,8 @@ type NetworkCfg with
member self.Affinity() : V1Affinity option =
let require = List.map requireNodeLabel self.missionContext.requireNodeLabels
let avoid = List.map avoidNodeLabel self.missionContext.avoidNodeLabels
// If we're trying to do even scheduling, we need to provide extra
// anti-affinity from the master nodes, in order to make the even-spread
// topology constraint happy. If we're doing uneven scheduling the taint
// on the master nodes will suffice to avoid them. This is all fairly
// mysterious kubernetes lore, likely subject to change.
let both = List.append require avoid

if self.missionContext.unevenSched then
affinity both
else
let nonMaster = avoidNodeLabel ("node-role.kubernetes.io/control-plane", None)
affinity (nonMaster :: both)
affinity both

member self.TopologyConstraints() : V1TopologySpreadConstraint array =
if self.missionContext.unevenSched then [||] else evenTopologyConstraints
Expand Down