Allow Ulimit to accept String in addition to i64#65
Open
8BitMate wants to merge 1 commit intostephanbuys:mainfrom
Open
Allow Ulimit to accept String in addition to i64#658BitMate wants to merge 1 commit intostephanbuys:mainfrom
8BitMate wants to merge 1 commit intostephanbuys:mainfrom
Conversation
This is to allow using environment variables in addition to hardcoded values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in main it is only possible to have
ulimitsmappings where the values are signed integers, but it doesn't take into account that the values can be passed as environment variables. This pull request addresses this by making theUlimittype accept eitherStringori64rather than justi64.There may be better ways of modeling this as well, but it does solve a problem I'm having where I'm unable to parse a valid docker compose configuration using
ulimits.