Support Symfony 3 #36
Conversation
SCDatetimeType::class symfony 3
|
Seems fine to me, I would need the Symfony 3 support for my project. So it would be nice to merge it ASAP 👍 |
|
Lo implemente aqui: https://github.com/MWSimple/AdminCrudBundle |
Form/Type/SCDatetimeType.php
Outdated
| * | ||
| */ | ||
| class DatetimeType extends AbstractType | ||
| class SCDatetimeType extends AbstractType |
There was a problem hiding this comment.
What is the reason for renaming the class as this is a BC break?
There was a problem hiding this comment.
Porque daba un error de que DatetimeType ya existe.
Because it gives an error that Datetime Type already exists.
There was a problem hiding this comment.
Can you please show the full error message and its stack trace?
composer.json
Outdated
| { | ||
| "name": "stephanecollot/datetimepicker-bundle", | ||
| "version": "1.0.1", | ||
| "version": "2.0.0", |
Form/Type/DatetimeType.php
Outdated
|
|
||
| /* | ||
| * This file is part of the SCDatetimepickerBundle package. | ||
| * This file is part of the DatetimepickerBundle package. |
|
@koprivajakub |
|
@stephanecollot could you merge the changes these guys made? :) I'd be needed to upgrade to Symfony 3 :) |
|
If testing use "mwsimple/datetimepicker-bundle": "2.0.0", |
|
New release 2.0 ? |
|
For Symphony 3.4, this is also needed: #45 |
6 participants
No description provided.