fix: use correct --model flag for pi coding agent#253
Open
Spacewalker215 wants to merge 1 commit intostephengpope:mainfrom
Open
fix: use correct --model flag for pi coding agent#253Spacewalker215 wants to merge 1 commit intostephengpope:mainfrom
Spacewalker215 wants to merge 1 commit intostephengpope:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the Pi coding agent's startup script that causes it to crash immediately when an
LLM_MODELoverride is provided.What changed:
Changed the
-mflag to--modelindocker/coding-agent/scripts/agents/pi-coding-agent/run.sh.Why:
The
piCLI does not recognize the-mshorthand. When a headless task or cluster worker runs with a specific model configured, the script previously passed(-m "$LLM_MODEL"), which resulted in a fatalError: Unknown option: -mcrash. The interactive script (interactive.sh) already correctly uses--model, so this bringsrun.shinto alignment.Type of Change
fix:)feat:)docs:)refactor:)Testing
Verified that
pisuccessfully accepts the--modelflag without throwing an unknown option error, allowing the container to proceed with execution.