Skip to content

Base graphics support#2

Open
zeileis wants to merge 5 commits intosteveharoz:mainfrom
zeileis:base-palette
Open

Base graphics support#2
zeileis wants to merge 5 commits intosteveharoz:mainfrom
zeileis:base-palette

Conversation

@zeileis
Copy link
Copy Markdown

@zeileis zeileis commented Nov 12, 2021

Steve, thanks again for putting together this package. As suggested on Twitter (https://twitter.com/AchimZeileis/status/1459103077798191130) I have added a painbow.colors(n, alpha = FALSE, rev = FALSE) function that will be particularly useful for base graphics.

In addition to the function itself, I made the following modifications:

  • Adding the corresponding documentation to the main painbow.Rd file, along with base graphics examples.
  • Adding the necessary base packages (grDevices, graphics, stats) in the DESCRIPTION along with some other changes and an increase of the minor version to reflect the new functionality.
  • Explicitly importing/exporting the functionality in the NAMESPACE.

I hope this facilitates integrating the modifications into the package. Happy to make further improvements if necessary.

Best wishes,
Achim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant