Rename old images refactor #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs to be tested still, added the 3 changes from the task https://stfc.atlassian.net/browse/CLDSCRM-2987
I have coded all these changes and refactors for the task https://stfc.atlassian.net/browse/CLDSCRM-2987 Has not been tested yet in a dev environment so will test that tomorrow and re get pr if successful.
khalford
reviewed
Oct 22, 2025
Comment on lines
40
to
62
| with open('/etc/packer-utils/templates/rally-test.json') as templatejson: | ||
| testtemplate = json.load(templatejson) | ||
|
|
||
| testtemplate["VMTasks.boot_runcommand_delete"][0]["args"]["image"]["name"] = next_image_name | ||
|
|
||
| with open("/etc/packer-utils/tests/" + next_image_name + ".json", "w") as testFile: | ||
| with open(f"/etc/packer-utils/tests/{next_image_name}.json", "w") as testFile: | ||
| json.dump(testtemplate, testFile) | ||
|
|
||
| mailfilepath = "/tmp/" + next_image_name + "-" + DATE + ".mail" | ||
|
|
||
| test = cl("INSTANCENAME=Prod; rally db create ;rally deployment create --name $INSTANCENAME --filename /opt/rally/existing.json ;rally deployment check $INSTANCENAME ; /opt/rally/bin/rally deployment use Prod ; /opt/rally/bin/rally task start /etc/packer-utils/tests/" + next_image_name + ".json | grep \"rally task report\" | grep \"json\" | sed 's/output.json/\/tmp\/" + next_image_name + "-" + DATE + "\.json/g'") | ||
| test = cl(f"INSTANCENAME=Prod; rally db create ;rally deployment create --name $INSTANCENAME --filename /opt/rally/existing.json ;rally deployment check $INSTANCENAME ; /opt/rally/bin/rally deployment use Prod ; /opt/rally/bin/rally task start /etc/packer-utils/tests/{next_image_name}.json | grep \"rally task report\" | grep \"json\" | sed 's/output.json/\/tmp\/{next_image_name}-{DATE}\.json/g'") | ||
| print(test) | ||
| reportcmd = test.split("\\n\\t")[3].replace("\\n", "").replace("'", "").replace('"','') | ||
| print(reportcmd) | ||
| print("GENERATING NEW REPORT", flush=True) | ||
| #rint(test + " /tmp/"+next_image_name+"-"+DATE+".json") | ||
| #cl(test + " /tmp/"+next_image_name+"-"+DATE+".json") | ||
|
|
||
| cl(reportcmd) | ||
|
|
||
| with open("/tmp/" + next_image_name + "-" + DATE + ".json") as testresultjson: | ||
| with open(f"/tmp/{next_image_name}-{DATE}.json") as testresultjson: | ||
| testresult = json.load(testresultjson) | ||
|
|
||
| testPassed = testresult["tasks"][0]["pass_sla"] | ||
|
|
||
| if testPassed: | ||
| print(next_image_name) |
Member
There was a problem hiding this comment.
We can remove everything to do with rally. We will not use Rally to test the images as it is not very useful and we are making our own QA workflow
Contributor
There was a problem hiding this comment.
When was that decision made? Do you have a draft of the tempest workflow?
|
|
||
| next_image_name = sys.argv[1] | ||
|
|
||
| current_image_name = next_image_name.replace("Next-", "") |
Member
There was a problem hiding this comment.
images are no longer called "Next-" instead it is "-baseline"
DavidFair
reviewed
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored script and changed some inefficiencies with print formatting. Haven't yet tested so going to create dev image to test with, therefore I have left it in this branch for now till I test to merge to main.
https://stfc.atlassian.net/browse/CLDSCRM-2987
From this task, can the reviewer check the code. Review if the logic is right from the description of the task.