Skip to content

Conversation

@RobertoRoos
Copy link
Contributor

Resolves:

I think this pipeline is now according what's considered modern.

Important! Now PyPi authentication is done based on a trusted publisher. This is the recommended authentication for deploy jobs like these. I set it up for my own testpypi and it's easy. See:
https://docs.pypi.org/trusted-publishers/using-a-publisher/

The test-version of these can be seen on my fork: RobertoRoos#1
Release results can be seen on my Test-PyPi: https://test.pypi.org/project/pyads-Roberto/#history
You could even try a test install with: pip install pyads_roberto -v --index-url https://test.pypi.org/simple/

This will obviously need a squash-merge... :')

@coveralls
Copy link

coveralls commented Jan 15, 2026

Pull Request Test Coverage Report for Build 21163041569

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 93.843%

Files with Coverage Reduction New Missed Lines %
/opt/hostedtoolcache/Python/3.12.12/x64/lib/python3.12/site-packages/pyads/pyads_ex.py 2 91.7%
/opt/hostedtoolcache/Python/3.9.25/x64/lib/python3.9/site-packages/pyads/pyads_ex.py 2 91.7%
Totals Coverage Status
Change from base Build 21134309020: -0.04%
Covered Lines: 10760
Relevant Lines: 11466

💛 - Coveralls

@stlehmann
Copy link
Owner

Having wheels for a bunch of operating systems is a big plus and makes live much easier for users that deal with compile issues.

@RobertoRoos RobertoRoos force-pushed the feature/ci-publish-done branch from b8e3d3a to 368bef2 Compare January 20, 2026 07:27
@stlehmann
Copy link
Owner

@RobertoRoos ist this MR ready to merge ... What do you think?

@RobertoRoos
Copy link
Contributor Author

Yeah, I think it's ready! I'm a tiny bit nervous about this working correctly, but it has been tested as much as possible at this point.

(And let's just not forget to squash-merge)

@stlehmann stlehmann changed the base branch from master to cibuildwheel January 28, 2026 19:16
@stlehmann
Copy link
Owner

I'll merge it in branch cibuildwheel for testing

@stlehmann stlehmann merged commit 9ed5d3e into stlehmann:cibuildwheel Jan 28, 2026
7 of 8 checks passed
stlehmann added a commit that referenced this pull request Jan 29, 2026
* Changed to `cibuildwheel` for wheel building across platforms (#496)

* Testing new release pipeline based on cibuildwheel
* Testing new release pipeline based on cibuildwheel

* Replacing custom platform naming by super-method

* Changed platform name logic

* Removed redundant manual packaging check

* Small pipeline changes, switched to my own test-pypi

* Bumped to version 9 for testing

* Removed py2 from wheel tag

* Restored on-release trigger

* Reverted all testing stuff back for production release

---------

Co-authored-by: Stefan Lehmann <stlm@posteo.de>

* Update workflow to upload to TestPyPi with correct environment settings

* Update TestPyPi URL to point to the correct package name

* Fix TestPyPi repository URL in workflow configuration

* Fix TestPyPi URL by adding trailing slashes for consistency

* Fix TestPyPi URL to use the correct project path

* Add testing job for built distributions in workflow

* Fix artifact name in download step for consistency across OS builds

* Fix artifact name pattern in download step for wildcard matching

* Fix artifact name pattern for consistency in upload and download steps

* Add editable install test job and update OS matrix for wheel builds

* Update project name for testpypi

* Update package name for installation in test step

* Update upload step to include additional dependencies and change repository URL for TestPyPi

* Revert project name to "pyads"

* Update upload step to publish to PyPi instead of TestPyPi

* Add entry for switching to cibuildwheel for CI wheel builds

---------

Co-authored-by: Robert <robert.soor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants