-
Notifications
You must be signed in to change notification settings - Fork 113
Changed to cibuildwheel for wheel building across platforms
#496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed to cibuildwheel for wheel building across platforms
#496
Conversation
Pull Request Test Coverage Report for Build 21163041569Details
💛 - Coveralls |
|
Having wheels for a bunch of operating systems is a big plus and makes live much easier for users that deal with compile issues. |
b8e3d3a to
368bef2
Compare
|
@RobertoRoos ist this MR ready to merge ... What do you think? |
|
Yeah, I think it's ready! I'm a tiny bit nervous about this working correctly, but it has been tested as much as possible at this point. (And let's just not forget to squash-merge) |
|
I'll merge it in branch cibuildwheel for testing |
* Changed to `cibuildwheel` for wheel building across platforms (#496) * Testing new release pipeline based on cibuildwheel * Testing new release pipeline based on cibuildwheel * Replacing custom platform naming by super-method * Changed platform name logic * Removed redundant manual packaging check * Small pipeline changes, switched to my own test-pypi * Bumped to version 9 for testing * Removed py2 from wheel tag * Restored on-release trigger * Reverted all testing stuff back for production release --------- Co-authored-by: Stefan Lehmann <stlm@posteo.de> * Update workflow to upload to TestPyPi with correct environment settings * Update TestPyPi URL to point to the correct package name * Fix TestPyPi repository URL in workflow configuration * Fix TestPyPi URL by adding trailing slashes for consistency * Fix TestPyPi URL to use the correct project path * Add testing job for built distributions in workflow * Fix artifact name in download step for consistency across OS builds * Fix artifact name pattern in download step for wildcard matching * Fix artifact name pattern for consistency in upload and download steps * Add editable install test job and update OS matrix for wheel builds * Update project name for testpypi * Update package name for installation in test step * Update upload step to include additional dependencies and change repository URL for TestPyPi * Revert project name to "pyads" * Update upload step to publish to PyPi instead of TestPyPi * Add entry for switching to cibuildwheel for CI wheel builds --------- Co-authored-by: Robert <robert.soor@gmail.com>
Resolves:
I think this pipeline is now according what's considered modern.
Important! Now PyPi authentication is done based on a trusted publisher. This is the recommended authentication for deploy jobs like these. I set it up for my own testpypi and it's easy. See:
https://docs.pypi.org/trusted-publishers/using-a-publisher/
The test-version of these can be seen on my fork: RobertoRoos#1
Release results can be seen on my Test-PyPi: https://test.pypi.org/project/pyads-Roberto/#history
You could even try a test install with:
pip install pyads_roberto -v --index-url https://test.pypi.org/simple/This will obviously need a squash-merge... :')