disable postgres tests by default#56
Open
rweng wants to merge 1 commit intostmichael:masterfrom
rweng:disable-postgres-by-default
Open
disable postgres tests by default#56rweng wants to merge 1 commit intostmichael:masterfrom rweng:disable-postgres-by-default
rweng wants to merge 1 commit intostmichael:masterfrom
rweng:disable-postgres-by-default
Conversation
Owner
|
Such a mechanism is already provided with the rake tasks. Executing But thanks to you, I found out that db specific tests haven't been run on travis until now. That's very naughty of me 😢 |
Owner
|
The travis issue has been fixed on the current master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a suggestion, but since I needed it anyway I made a pull-request out of it:
Let's give the option to enable and disable platform/database specific tests. Why? For me, it's just that I have a different connection string for postgres. We could make it possible to pass it in, however, someone else might not have postgresql installed. As long as the platform-specific tests are run on travis before merge, I think it's more intuitive (for new developers) if the tests pass right away and no extra setup is required.
Let me know what you think.