Replace Agahnim item by an eleventh dungeon#22
Open
Ninban wants to merge 3 commits intostochaztic:masterfrom
Open
Replace Agahnim item by an eleventh dungeon#22Ninban wants to merge 3 commits intostochaztic:masterfrom
Ninban wants to merge 3 commits intostochaztic:masterfrom
Conversation
This fixes location tracking when Agahnim is marked as beaten
Owner
|
As is this will give errors when people try to use existing rooms (NaNs on smallkeys[11] from Firebase for example, and I think the default layout is expecting the agahnim item that no longer exists), Would you have time to look into ways to clean this up? I'm hesitant to merge this and break existing trackers, as most people probably aren't checking the changelog regularly. |
Author
|
No problem, thanks for finding this out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal is to have the Castle Tower available as a dungeon to track in keysanity mode with its two small keys while combining Agahnim's status as a boss.
This also has the side-effect of including the dungeon on the location tracker. For now, it returns item availability according to normal modes, so it has no chests, just the boss itself. In the future there will be two chests available in the dungeon for keysanity logic.
You can test on my own firebase project: https://lttp-tracker-f0591.firebaseapp.com/