Skip to content

adan optimizer#58

Open
cvnad1 wants to merge 1 commit intostockeh:mainfrom
cvnad1:adan
Open

adan optimizer#58
cvnad1 wants to merge 1 commit intostockeh:mainfrom
cvnad1:adan

Conversation

@cvnad1
Copy link
Copy Markdown

@cvnad1 cvnad1 commented Jan 9, 2025

Fixes #56

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@cvnad1
Copy link
Copy Markdown
Author

cvnad1 commented Jan 9, 2025

Hi @stockeh,

Added the Adan Optimizer implementation. Thanks for letting me add this. Kindly review the PR.

@stockeh
Copy link
Copy Markdown
Owner

stockeh commented Mar 1, 2025

@cvnad1 would you be able to resolve the linting with isort . && black . ? Also, any ideas why the test are failing? We should also run rosenbrock so that the docs can be updated correctly.

@cvnad1
Copy link
Copy Markdown
Author

cvnad1 commented Mar 8, 2025

@stockeh do not know why the tests are failing as the tests in MLX repo were passing, but can check on the linting. Please feel free to share your thoughts. I too will try to see what can be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adan Optimizer

2 participants