Skip to content

capi changes#3026

Merged
openshift-merge-bot[bot] merged 1 commit intostolostron:mainfrom
cameronmwall:capi-changes
Apr 28, 2026
Merged

capi changes#3026
openshift-merge-bot[bot] merged 1 commit intostolostron:mainfrom
cameronmwall:capi-changes

Conversation

@cameronmwall
Copy link
Copy Markdown
Contributor

@cameronmwall cameronmwall commented Mar 31, 2026

Description

Please provide a brief description of the purpose of this pull request.

Related Issue

If applicable, please reference the issue(s) that this pull request addresses.

Changes Made

Provide a clear and concise overview of the changes made in this pull request.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Summary by CodeRabbit

  • New Features

    • Bundle automation CLI now accepts previously-unrecognized command-line arguments and forwards them to downstream operations, enabling more flexible and customizable automation workflows.
  • Bug Fixes

    • CLI no longer fails on unknown tokens; unexpected arguments are captured and passed through instead of causing errors.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 03716c9c-6e71-4b82-ae9c-aa5b38dbb733

📥 Commits

Reviewing files that changed from the base of the PR and between b6fd19b and a930997.

📒 Files selected for processing (1)
  • hack/bundle-automation/generate-shell.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • hack/bundle-automation/generate-shell.py

📝 Walkthrough

Walkthrough

The CLI parsing in hack/bundle-automation/generate-shell.py was changed to capture unknown tokens and forward them: parse_known_args() now returns extra_args, and prepare_and_execute and main signatures were extended to accept and pass extra_args into the execution pipeline.

Changes

Cohort / File(s) Summary
Argument Pass-through Enhancement
hack/bundle-automation/generate-shell.py
Replaced parse_args() with parse_known_args() to collect unknown CLI tokens as extra_args. Updated function signatures: prepare_and_execute(..., extra_args) and main(args, extra_args). extra_args are concatenated into operations_args before calling execute_script.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇 I nibble at flags once missed,
Now unknown hops join the list.
Passed along each winding trail,
No more arguments shall fail.
A tidy bundle, tail to tail. 🥕

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is entirely templated with no concrete information filled in; all required sections contain only placeholder text or are left unchecked. Complete all required sections: provide a brief purpose statement, reference any related issues, summarize the actual changes made, check applicable checklist items, and add any relevant notes for reviewers.
Title check ❓ Inconclusive The title 'capi changes' is vague and generic, failing to convey the specific nature of the modifications made to the codebase. Replace with a more descriptive title that clearly captures the main change, such as 'Support passing through extra CLI arguments in bundle automation script' or 'Add extra_args parameter support to generate-shell.py'.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@hack/bundle-automation/generate-shell.py`:
- Around line 153-156: The current concatenation of extra_args into
operations_args uses " ".join(extra_args), which corrupts arguments containing
whitespace when later parsed by execute_script using args.split(); change the
flow to build and pass a properly quoted string (use shlex.join(extra_args) when
you must keep a single string) and update execute_script to parse with
shlex.split() instead of args.split(), or better yet propagate a list of
arguments (avoid string joins) so functions like execute_script accept and
handle a list; update references to extra_args, operations_args and the
execute_script call accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eca1819e-20ad-4bce-bc9d-c74e985a093f

📥 Commits

Reviewing files that changed from the base of the PR and between 6179df7 and b6fd19b.

📒 Files selected for processing (1)
  • hack/bundle-automation/generate-shell.py

Comment thread hack/bundle-automation/generate-shell.py
Signed-off-by: Cameron Wall <cwall@redhat.com>
Copy link
Copy Markdown
Contributor

@ngraham20 ngraham20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cameronmwall, ngraham20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cameronmwall,ngraham20]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 91abc79 into stolostron:main Apr 28, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants