Skip to content

MGMT-19879: Binding-day-2-host-to-cluster-defaults-host-to-worker-role#4494

Open
ElayAharoni wants to merge 1 commit intostolostron:mainfrom
ElayAharoni:Binding-day-2-host-to-cluster-defaults-host-to-worker-role
Open

MGMT-19879: Binding-day-2-host-to-cluster-defaults-host-to-worker-role#4494
ElayAharoni wants to merge 1 commit intostolostron:mainfrom
ElayAharoni:Binding-day-2-host-to-cluster-defaults-host-to-worker-role

Conversation

@ElayAharoni
Copy link
Contributor

@ElayAharoni ElayAharoni commented May 14, 2025

https://issues.redhat.com/browse/MGMT-19879
removed the default behavior that was setting the role for any added host to be worker.
added the option to edit the host role in the add hosts modal.

Signed-off-by: Elay Aharoni <elayaha@gmail.com>
@openshift-ci
Copy link

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ElayAharoni
Once this PR has been reviewed and has the lgtm label, please assign randy424 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ElayAharoni
Copy link
Contributor Author

/ok-to-test

@sonarqubecloud
Copy link

@ElayAharoni
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented May 15, 2025

@ElayAharoni: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check 219eb16 link true /test check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants