🐛 Gracefully skip tls-profile-sync sidecar when image env var is missing#1037
Open
zhujian7 wants to merge 1 commit intostolostron:mainfrom
Open
🐛 Gracefully skip tls-profile-sync sidecar when image env var is missing#1037zhujian7 wants to merge 1 commit intostolostron:mainfrom
zhujian7 wants to merge 1 commit intostolostron:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When TLS_PROFILE_SYNC_IMAGE is not set, getTLSProfileSyncImage() now returns an empty string instead of a fatal error. The Generate() function logs a warning and skips sidecar injection, allowing the import secret to still be created. This fixes a regression where manually importing OpenShift discovered clusters would fail because the env var was not yet injected by backplane-operator. Ref: https://redhat.atlassian.net/browse/ACM-32524 Signed-off-by: Jian Zhu <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
fix-tls-sidecar-missing-env-graceful
branch
from
c9ad47c to
16f6e20
Compare
Contributor
Author
|
/hold |
openshift-ci
Bot
added
dco-signoff: yes
do-not-merge/hold
and removed
dco-signoff: no
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TLS_PROFILE_SYNC_IMAGEenv var is not set,getTLSProfileSyncImage()now returns an empty string instead of a fatal errorGenerate()logs a warning and skips sidecar injection, allowing the import secret to still be createdRelated issue(s)
Test plan
TLS_PROFILE_SYNC_IMAGEis not setTLS_PROFILE_SYNC_IMAGEis properly set