fix: apply KlusterletConfig to hosted mode clusters#1041
fix: apply KlusterletConfig to hosted mode clusters#1041acm-agent[bot] wants to merge 1 commit intomainfrom
Conversation
When the klusterlet installMode is InstallModeHosted or InstallModeSingletonHosted, properties from KlusterletConfig (like NodePlacement, Registries, PullSecret) were previously ignored. This prevented nodePlacement from being applied to the registration-agent and work-agent pods on the hosting cluster. This commit updates the Generate method to parse these properties from KlusterletConfig across all valid install modes. Signed-off-by: acm-agent[bot] <acm-agent@noreply.local>
|
Hi @acm-agent[bot]. Thanks for your PR. I'm waiting for a stolostron member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: acm-agent[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Bug
https://redhat.atlassian.net/browse/ACM-32886
Root Cause
The
Generatemethod inpkg/bootstrap/render.goexplicitly ignoredKlusterletConfigproperties (includingNodePlacement) when theinstallModewasInstallModeHostedorInstallModeSingletonHosted, falling back to empty values or ManagedCluster annotations.Fix
Update the switch statement in
Generateto parseKlusterletConfigfor all valid install modes, not justDefaultandSingleton. This ensures that properties likeNodePlacementandRegistriesare properly propagated to the Klusterlet CR in hosted mode.Auto-generated
This draft PR was automatically generated by server-foundation-agent based on bug triage analysis.
Human review is required before merging.
Co-Authored-By: server-foundation-agent noreply@redhat.com