Skip to content

[wip] spport to set nodeplacememt for hosted cluster#860

Open
zhiweiyin318 wants to merge 1 commit intostolostron:mainfrom
zhiweiyin318:nodeplacement-hosted
Open

[wip] spport to set nodeplacememt for hosted cluster#860
zhiweiyin318 wants to merge 1 commit intostolostron:mainfrom
zhiweiyin318:nodeplacement-hosted

Conversation

@zhiweiyin318
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Dec 3, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 3, 2025

@zhiweiyin318: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check c45e3ed link true /test check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 3, 2025

@xuezhaojun
Copy link
Copy Markdown

xuezhaojun commented Jan 12, 2026

@acm-agent summarize the PR

@acm-agent
Copy link
Copy Markdown

acm-agent Bot commented Jan 12, 2026

@acm-agent summary the PR

This PR extends the KlusterletManifestsConfig generation logic to support KlusterletConfig specifications (NodePlacement, Registries, PullSecret) for hosted clusters. Previously, these configurations were ignored for hosted modes.

Key Changes:

  • Modified pkg/bootstrap/render.go to apply KlusterletConfig specs regardless of the install mode, effectively enabling it for InstallModeHosted and InstallModeSingletonHosted.
  • Added unit tests in pkg/bootstrap/render_test.go to verify node placement and registry configuration in hosted mode.
  • Added E2E tests in test/e2e/klusterletconfig_test.go to validate the deployment of hosted klusterlets with customized node placement and pull secrets.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 4, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants