https://issues.redhat.com/browse/ACM-29840#8605
Open
dockerymick wants to merge 3 commits into2.16_stagefrom
Open
https://issues.redhat.com/browse/ACM-29840#8605dockerymick wants to merge 3 commits into2.16_stagefrom
dockerymick wants to merge 3 commits into2.16_stagefrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dockerymick The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
smcavey
reviewed
Feb 24, 2026
dockerymick
commented
Feb 24, 2026
swopebe
reviewed
Feb 24, 2026
| ---- | ||
|
|
||
| . List the resources in the allow (`data.AllowedResources`) and deny list (`data.DeniedResources`) sections within the config map. Your config map might resemble the following YAML file: | ||
| . List the resources in the allow (`data.AllowedResources`) and deny list (`data.DeniedResources`) sections within the config map. |
Contributor
There was a problem hiding this comment.
This should be rewritten so that we don't have the spec in parenthesis, not sure how that passed peer review the first time.
swopebe
reviewed
Feb 24, 2026
|
|
||
| . List the resources in the allow (`data.AllowedResources`) and deny list (`data.DeniedResources`) sections within the config map. Your config map might resemble the following YAML file: | ||
| . List the resources in the allow (`data.AllowedResources`) and deny list (`data.DeniedResources`) sections within the config map. | ||
| .. Collect `services` and `pods` from all `apiGroups`, while also collecting allowing all resources from the `admission.k8s.io` and `authentication.k8s.io` `apiGroups`. |
Contributor
There was a problem hiding this comment.
Here if we are coding these, we need to name what they are. Or don't code.
swopebe
reviewed
Feb 24, 2026
| . List the resources in the allow (`data.AllowedResources`) and deny list (`data.DeniedResources`) sections within the config map. Your config map might resemble the following YAML file: | ||
| . List the resources in the allow (`data.AllowedResources`) and deny list (`data.DeniedResources`) sections within the config map. | ||
| .. Collect `services` and `pods` from all `apiGroups`, while also collecting allowing all resources from the `admission.k8s.io` and `authentication.k8s.io` `apiGroups`. | ||
| .. Configure your config map to prevent the central collection of `secrets` from all `apiGroups`, while preventing the collection of `policies`, `iampolicies`, and `certificatepolicies` from the `apiGroup` `admission.k8s.io`. |
Contributor
There was a problem hiding this comment.
I will pick up on this in a sec.
Contributor
There was a problem hiding this comment.
We kinda need to do the same with all of these, in that we typically don't just use the spec without naming it but I understand that would mean a lot of unnecessary rewrite. Recommend:
Configure your config map to prevent the central collection of secrets from all apiGroups specifications, while preventing the collection of policies, iampolicies, and certificatepolicies from the apiGroup admission.k8s.io specification.
dockerymick
commented
Feb 24, 2026
| ---- | ||
|
|
||
| . List the resources in the allow (`data.AllowedResources`) and deny list (`data.DeniedResources`) sections within the config map. Your config map might resemble the following YAML file: | ||
| . List the resources in the allow (`data.AllowedResources`) and deny list (`data.DeniedResources`) sections within the config map. |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| . List the resources in the allow (`data.AllowedResources`) and deny list (`data.DeniedResources`) sections within the config map. | |
| . List the resources in the `data.AllowedResources` and the `data.DeniedResources` fields within the config map. |
|
|
||
| . List the resources in the allow (`data.AllowedResources`) and deny list (`data.DeniedResources`) sections within the config map. Your config map might resemble the following YAML file: | ||
| . List the resources in the allow (`data.AllowedResources`) and deny list (`data.DeniedResources`) sections within the config map. | ||
| .. Collect `services` and `pods` from all `apiGroups`, while also collecting allowing all resources from the `admission.k8s.io` and `authentication.k8s.io` `apiGroups`. |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| .. Collect `services` and `pods` from all `apiGroups`, while also collecting allowing all resources from the `admission.k8s.io` and `authentication.k8s.io` `apiGroups`. | |
| .. Collect services and pods from all `apiGroups`, while also collecting all resources from the `admission.k8s.io` and `authentication.k8s.io` `apiGroups`. |
swopebe
reviewed
Feb 24, 2026
| - iampolicies | ||
| - certificatepolicies | ||
| ---- | ||
| *Note:* If you do not provide a config map, all resources are collected by default. When you specify `AllowedResources`, all other resources are automatically excluded. If you list resources in both `AllowedResources` and `DeniedResources`, it is excluded from the collection. |
Contributor
There was a problem hiding this comment.
Suggested change
| *Note:* If you do not provide a config map, all resources are collected by default. When you specify `AllowedResources`, all other resources are automatically excluded. If you list resources in both `AllowedResources` and `DeniedResources`, it is excluded from the collection. | |
| *Note:* If you do not provide a config map, all resources are collected by default. When you specify `AllowedResources`, all other resources are automatically excluded. If you list resources in both the `AllowedResources` and `DeniedResources` specifications, it is excluded from the collection. |
Contributor
There was a problem hiding this comment.
And then what is "it" in "it is excluded" -- that should be replaced with what it is to reduce confusion.
swopebe
requested changes
Feb 24, 2026
| - iampolicies | ||
| - certificatepolicies | ||
| ---- | ||
| *Note:* If you do not provide a config map, all resources are collected by default. When you specify `AllowedResources`, all other resources are automatically excluded. If you list resources in both `AllowedResources` and `DeniedResources`, it is excluded from the collection. |
Contributor
There was a problem hiding this comment.
And then what is "it" in "it is excluded" -- that should be replaced with what it is to reduce confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also removed callouts from the file