Skip to content

Added Polish localization#352

Open
bytepl wants to merge 3 commits intostonerl:mainfrom
bytepl:development
Open

Added Polish localization#352
bytepl wants to merge 3 commits intostonerl:mainfrom
bytepl:development

Conversation

@bytepl
Copy link
Copy Markdown

@bytepl bytepl commented Apr 1, 2026

Summary

  • Language(s): Polish
  • Completion status: 100%
  • Existing translations modified: No
  • Other changes (if any): None
  • Notes about tone / regional variant (optional): None

Test plan

  • Open Thaw.xcodeproj in Xcode
  • Open Thaw → Resources → Localizable.xcstrings
  • Confirm the new/updated language shows the expected completion
  • Build succeeds without errors
  • (Optional) Switch system language to this locale and verify UI strings look correct

Summary by CodeRabbit

  • New Features

    • Added Polish language support
  • Chores

    • Updated code signing configuration for macOS builds

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 88acab57-3ebf-49a9-b9a4-b7ed9e33f026

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding Polish localization support to the project.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description follows the localization template structure with all required sections completed: language, completion status, modifications, other changes, and test plan.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Thaw.xcodeproj/project.pbxproj`:
- Line 501: The build setting override that forces ad-hoc signing
("CODE_SIGN_IDENTITY[sdk=macosx*]" = "-") for the MenuBarItemService target
breaks XPC same-team checks; remove that override from the MenuBarItemService
target in the project.pbxproj (delete the CODE_SIGN_IDENTITY[sdk=macosx*] = "-"
entry or restore to the target's default/automatic signing) so the service is
signed with the app team ID and the connection in
MenuBarItemServiceConnection.swift
(session.setPeerRequirement(.isFromSameTeam())) started from AppState.swift can
succeed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 70b59654-c4d0-4bd1-98a8-97ddc3584ce3

📥 Commits

Reviewing files that changed from the base of the PR and between 926d548 and 3cc634f.

📒 Files selected for processing (2)
  • Thaw.xcodeproj/project.pbxproj
  • Thaw/Resources/Localizable.xcstrings

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@diazdesandi diazdesandi added the translation Internationalization (multi-language support) label Apr 4, 2026
@diazdesandi diazdesandi self-requested a review April 4, 2026 20:43
@diazdesandi diazdesandi added this to the 1.2.0 milestone Apr 4, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 4, 2026

Copy link
Copy Markdown
Author

@bytepl bytepl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation Internationalization (multi-language support)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants