Skip to content

Update InputEventTests.cs to catch type failure#2

Merged
AussieScorcher merged 2 commits intostopbars:mainfrom
bstudtma:fix-input-event-test
Aug 20, 2025
Merged

Update InputEventTests.cs to catch type failure#2
AussieScorcher merged 2 commits intostopbars:mainfrom
bstudtma:fix-input-event-test

Conversation

@bstudtma
Copy link
Copy Markdown
Contributor

Summary

Detect a failed test for TestInputEventGetSet

Changes Made

Detect when the type is None

Additional Information

I'm not sure certain events would actually pass, but it seems that grabbing the first fails silently when testing the C172 and SR22T.

Author Information

Discord Username: bstudtma


Checklist:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Copilot AI review requested due to automatic review settings August 19, 2025 00:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the InputEventTests by adding explicit failure detection when an input event's value type cannot be determined. The change improves test reliability by catching cases where the type detection fails silently, particularly observed with C172 and SR22T aircraft models.

  • Adds explicit handling for unknown value types in input event testing
  • Improves test feedback by logging specific failure reasons
  • Ensures tests fail explicitly rather than silently when type detection fails

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@AussieScorcher AussieScorcher merged commit 6dfbc6c into stopbars:main Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants