Update InputEventTests.cs to catch type failure#2
Merged
AussieScorcher merged 2 commits intostopbars:mainfrom Aug 20, 2025
Merged
Update InputEventTests.cs to catch type failure#2AussieScorcher merged 2 commits intostopbars:mainfrom
AussieScorcher merged 2 commits intostopbars:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the InputEventTests by adding explicit failure detection when an input event's value type cannot be determined. The change improves test reliability by catching cases where the type detection fails silently, particularly observed with C172 and SR22T aircraft models.
- Adds explicit handling for unknown value types in input event testing
- Improves test feedback by logging specific failure reasons
- Ensures tests fail explicitly rather than silently when type detection fails
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
AussieScorcher
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detect a failed test for TestInputEventGetSet
Changes Made
Detect when the type is None
Additional Information
I'm not sure certain events would actually pass, but it seems that grabbing the first fails silently when testing the C172 and SR22T.
Author Information
Discord Username: bstudtma
Checklist: