Fix SetInputEvent to accept hash as ulong#5
Merged
AussieScorcher merged 1 commit intostopbars:mainfrom Aug 22, 2025
Merged
Conversation
Send event hash as ulong
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a data type mismatch in the SimConnect input event handling by changing the hash parameter from uint to ulong in both the native P/Invoke declaration and its usage. This aligns the wrapper with the actual SimConnect SDK requirements and prevents potential data truncation issues when working with input event hashes.
Key Changes
- Updated P/Invoke signature for
SimConnect_SetInputEventto acceptulonghash parameter - Modified all calls to use
ulongcasting instead ofuintcasting for the hash parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SimConnect.NET/SimConnectNative.cs | Updated P/Invoke declaration to use ulong for hash parameter |
| src/SimConnect.NET/InputEvents/InputEventManager.cs | Updated method calls to cast hash as ulong instead of uint |
AussieScorcher
approved these changes
Aug 22, 2025
llamavert
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send event hash as ulong
Summary
Fixed SetInputEvent to accept hash as ulong
Changes Made
Fixed SetInputEvent to accept hash as ulong
Additional Information
Tested with AS1000_CONTROLPAD_1 on the SR22T sending a value of 0.0
Author Information
Discord Username: bstudtma
VATSIM CID:
Checklist: