Merged
Conversation
Fix GetInputEventAsync to read bytes dynamically based on type
AussieScorcher
approved these changes
Aug 23, 2025
Member
|
Really great work, thanks for fixing this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix GetInputEventAsync to read value bytes dynamically based on type.
Summary
Fixed GetInputEventAsync response handling to read the type and value correctly.
Changes Made
Removed None from SimConnectInputEventType - since it docs seem incorrect. Verified by comparing other code on GitHub and from testing.
Also, C:\MSFS 2024 SDK\SimConnect SDK\include\SimConnect.h shows the enum as:
SIMCONNECT_ENUM SIMCONNECT_INPUT_EVENT_TYPE : DWORD
{
SIMCONNECT_INPUT_EVENT_TYPE_DOUBLE,
SIMCONNECT_INPUT_EVENT_TYPE_STRING
};
Created a new struct for SimConnectRecvGetInputEventHeader without Value
Marshall SimConnectRecvGetInputEventHeader without value and read the value dynamically based on type and remaining bytes.
Fixed setting the Hash based on the requested Hash instead of RequestId from the response.
Additional Information
Tested by enumerating over all available input events and reading each value.
Also, the standard test case should now pass since it detects the double correctly.
Author Information
Discord Username: bstudtma
Checklist: