Fix SimConnect_AddToDataDefinition to change default datumType to 4 and datumId to 0xFFFFFFFF#8
Merged
AussieScorcher merged 1 commit intostopbars:mainfrom Aug 24, 2025
Conversation
Fixed defaults for SimConnect_AddToDataDefinition
Contributor
Author
|
This is needed for a bigger change I was working on... which you can check out here: https://github.com/bstudtma/SimConnect.NET/blob/add-dynamic-structures/MyApp/Program.cs Was trying to add support for getting structures dynamically and ran into this bug. The bug causes a single var to be returned even if multiple were added to the definition. |
AussieScorcher
approved these changes
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed defaults for SimConnect_AddToDataDefinition
Summary
Fixed defaults so to allow multiple AddToDataDefinition
Before this changed, multiple calls to AddToDataDefinition would overwrite each other even if for a different var. This fix will allow multiple vars for a single definition.
Changes Made
Synced defaults with C:\MSFS 2024 SDK\SimConnect SDK\include\SimConnect.h
Additional Information
This is blocking a feature branch I'm working on to allow dynamic structures.
Author Information
Discord Username: bstudtma
Checklist: