added password reset#8
added password reset#8nopolabs wants to merge 1 commit intostormpath:masterfrom nopolabs:add-password-reset
Conversation
|
Thanks for the PR! In reviewing it I found some things we need to change:
|
|
I agree with your first two points. On the fence with respect to the third, this app is a minimal demonstration of the Stormpath API, not so much of good UX. I considered including the email address in the "reset email sent" message and decided against it since it could potentially leak an email address to someone who requested a password reset and provided a username. I think the last point is a good one, this is a common flaw in demo apps and one prone to cut and paste replication. Ultimately I think that sendPasswordResetEmail should be a method in the passport-stormpath module, but that seemed beyond the scope of what I wanted to do last night ;) Take what you like. |
|
ah so close :( |
Added password reset to the sample app.
per issue #6