Unit 14: portfolio fix — replace 404'ing /assets/js/portfolio.js + static→assets migration#16
Open
stradichenko wants to merge 1 commit intomainfrom
Open
Unit 14: portfolio fix — replace 404'ing /assets/js/portfolio.js + static→assets migration#16stradichenko wants to merge 1 commit intomainfrom
stradichenko wants to merge 1 commit intomainfrom
Conversation
- portfolio.html: replace <script src="/assets/js/portfolio.js"> (which 404s in production because /assets is not published) with a proper resources.Get | js.Build | fingerprint pipeline emitting an SRI integrity attribute. - Move the ~160-LOC inline portfolio <script> into the existing assets/js/portfolio.js (or a portfolio-page.js companion). - Move static/img/logo.svg -> assets/img/logo.svg; update partials/header.html to use resources.Get | fingerprint. - Move static/images/profile.png -> assets/images/profile.png; update layouts/page/about.html to use resources.Get | images.Resize "200x webp". - Move static/images/portfolio/** -> assets/images/portfolio/**; update portfolio/single.json (already uses resources.Match) and portfolio.html accordingly. - Move static/netlify.toml to repo root (or document its real home). - portfolio/single.json: replace now.Format with time.Format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
portfolio.html: replace<script src="/assets/js/portfolio.js">(which 404s in production because/assetsis not published) with a properresources.Get | js.Build | fingerprintpipeline emitting an SRI integrity attribute.<script>into the existingassets/js/portfolio.js(or aportfolio-page.jscompanion).static/img/logo.svg→assets/img/logo.svgand updatepartials/header.htmlto useresources.Get | fingerprint.static/images/profile.png→assets/images/profile.pngand updatelayouts/page/about.htmlto useresources.Get | images.Resize "200x webp".static/images/portfolio/**→assets/images/portfolio/**(8 images); updateportfolio/single.json(already usesresources.Match) andportfolio.htmlaccordingly.static/netlify.tomlto repo root.portfolio/single.json: replacenow.Formatwithtime.Format.Notes for reviewer
header.html(logo block).Test plan
curl /portfolio/succeeds./assets/js/portfolio.js(was the original P0 bug).images.Resize.Part of the PKB-theme modernization batch (15 units).