generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 535
bidi - remove python 3.11+ features #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+136
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
pgrayy
commented
Dec 5, 2025
pgrayy
commented
Dec 5, 2025
…nto bidi-remove-311-features
pgrayy
commented
Dec 5, 2025
zastrowm
previously approved these changes
Dec 5, 2025
pgrayy
commented
Dec 5, 2025
…nto bidi-remove-311-features
pgrayy
commented
Dec 8, 2025
pgrayy
commented
Dec 8, 2025
mkmeral
reviewed
Dec 8, 2025
zastrowm
reviewed
Dec 8, 2025
zastrowm
previously approved these changes
Dec 8, 2025
…nto bidi-remove-311-features
pgrayy
commented
Dec 8, 2025
zastrowm
previously approved these changes
Dec 9, 2025
…nto bidi-remove-311-features
zastrowm
approved these changes
Dec 10, 2025
mkmeral
approved these changes
Dec 11, 2025
Contributor
mkmeral
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do it as another step, but can we also update AGENTS.md :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing the python 3.11+ features used directly in the bidi subpackage. Specifically I am replacing use of:
asyncio.TaskGroup: Used inBidiAgent.run. Replacing with an internally implemented shim of TaskGroup.ExceptionGroup: Used in_async.stop_all. Replacing with a customRuntimeException.ExceptionGroup. More likely, if they are catching unexpected, internal errors, they would do so withException. So for all intents and purposes, I would call this a backwards compatible change. Regardless, bidi is experimental.Note, this is part of a larger effort to have bidi run in Python 3.10 and 3.11. Only the
BidiNovaSonicModelprovider requires Python 3.12+. The rest of bidi however should be runnable in all other versions of Python that Strands as a whole supports.Related Issues
#1299
Documentation PR
N/A
Type of Change
Other (please describe): On the way to supporting 3.10 and 3.11 for bidi.
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run preparehatch run bidi:prepare: Updated some existing unit tests.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.