fix: Tool watcher checks for tools repo even if initially missing #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unshure
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
zastrowm
reviewed
Sep 30, 2025
src/strands/tools/registry.py
Outdated
| logger.debug("tools_dir=<%s> | found tools directory", directory) | ||
| else: | ||
| logger.debug("tools_dir=<%s> | tools directory not found", directory) | ||
| logger.debug( |
There was a problem hiding this comment.
Any reason not to throw? I feel like if you enable this option and there is no directory, it's not obvious that it's not going to work.
I feel like because they explicitly opt-ed in, we should either throw or create the directory
There was a problem hiding this comment.
Backwards compatibility ¯\_(ツ)_/¯
I actually mean to update this to a warning instead of debug, so at least this is more visible
Unshure
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
| master_handler = self.MasterChangeHandler(dir_str) | ||
| ToolWatcher._shared_observer.schedule(master_handler, dir_str, recursive=False) | ||
|
|
||
| ToolWatcher._shared_observer.schedule(master_handler, str(tools_dir), recursive=False) |
There was a problem hiding this comment.
sorry, can you explain why this is fixing the bug? Is there some mutation happening?
Like like L111 has dir_str = str(tools_dir) so I'm not sure whats changing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the issue where we do not detect tools in the local tools repo if no tools exits in it initially. This fix updates the agent behavior where if the
toolsrepo exists with no tools, it will detect tools added to the directory.Note: This feature will not detect tools if the directory does not exits. The directory must exist first, and can be empty, for this feature to work.
Related Issues
#264
Documentation PR
TBD
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.