feat: add OpenAI Responses API model implementation #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgitika
requested a deployment
to
manual-approval
GitHub Actions
Waiting
| logger.debug("config=<%s> | initializing", self.config) | ||
|
|
||
| @override | ||
| def update_config(self, **model_config: Unpack[OpenAIResponsesConfig]) -> None: # type: ignore[override] |
There was a problem hiding this comment.
Just wondering why we need it here: # type: ignore[override]
There was a problem hiding this comment.
good question! the base class accepts **model_config: Any but here we use the more specific Unpack[OpenAIResponsesConfig] type which raises the mypy error.
openai.py also has this: https://github.com/strands-agents/sdk-python/blob/main/src/strands/models/openai.py#L73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements OpenAI Responses API as a separate model provider supporting streaming, structured output and tool calling.
Note: this commit does not include the extra capabilities that the Responses API supports such as the built-in tools and the stateful conversation runs.
Related Issues
#253
Documentation PR
TODO; coming next: will be adding a section for the Responses API within the existing openai model page
Type of Change
New feature
Testing
Added a unit test file similar to the existing
test_openai.pymodel provider. Reusing the integ tests in the same filetest_model_openai.pyusingpytest.parameterizewithOpenAIResponsesmodel so that I could test that the funcitonality is the same between the two models.I ran everything in the CONTRIBUTING.md file.
hatch run integ-test================== 81 passed, 68 skipped, 49 warnings in 106.56s (0:01:46) ==========
hatch run test-integ tests_integ/models/test_model_openai.py -v============= 18 passed, 2 skipped in 13.44s =============
pre-commit run --all-fileshatch run prepare--> yes, all tests passChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.