Fix additional_args passing in SageMakerAIModel #983
+50
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error where passing an additional_args dict to SageMakerAIModel would raise an AttributeError because Python dicts have no '__dict__' attribute. Fixes strands-agents#982
Fix typing for SageMakerAIModel.endpoint_config which was previously being treated as an arbitrary dictionary due to init assignment.
Fix typing for SageMakerAIModel.payload_config, which was previously being treated as a plain dict due to init assignment.
Add a test to check for insertion of endpoint config additional_args
athewsey
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Copy SageMakerAIPayloadSchema's additional_args into request payloads where provided - previously these were being ignored. Includes unit tests.
athewsey
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
|
(Expanded scope to include fixing the second related issue with payload additional_args found from exploring the first one) |
athewsey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SageMakerAIModel.endpoint_configandSageMakerAIModel.payload_configto use the proper typed dicts for these structures rather than a plaindict()(coming from the shallow copy in the model constructor)format_request()correctly includes additional_args (both types)Related Issues
Fixes #982, Fixes #984
Documentation PR
None
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
additional_argsfeature, but it seems like that is missing from the SageMaker model provider doc in the Strands-Agents User Guide.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.