fix: address PR #84 follow-up items (registry tests, asset presence check, dead code removal)#106
Merged
cagataycali merged 1 commit intostrands-labs:mainfrom Apr 27, 2026
Conversation
Tasks completed: - Task 1: SimWorld._model/_data/_backend_state docstring — already done in PR strands-labs#84 merge, verified present in models.py - Task 2: Add test_registry_resolves.py — parametrised over all 68 robots, validates asset fields, path safety, XML extensions, and API resolve. 322 tests covering sim + hardware-only robots - Task 3: Add is_robot_asset_present() — lightweight filesystem-only check (no auto-download, no mesh walk, no network). Rewired list_available_robots() to use it for status queries - Task 4: Fix stale [mujoco] extra reference — already corrected to [sim-mujoco] in download.py line 16 during PR strands-labs#85, verified - Task 5: Remove dead dedup check in get_search_paths() — 'user_cache not in paths' was always True since paths starts empty. Removed the dead check, kept the meaningful cwd_assets dedup Closes strands-labs#105
awsarron
approved these changes
Apr 27, 2026
github-project-automation
Bot
moved this from In review
to Done
in Strands Labs - Robots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all 5 follow-up tasks from issue #105 (spawned at PR #84 merge).
Changes
Task 2: Registry resolution guard (
tests/test_registry_resolves.py)robots.json..), XML extensions, API resolveasimov_v0.xml→xmls/asimov.xmlclass of bug)Task 3: Lightweight asset presence check (
assets/manager.py)is_robot_asset_present(name) -> bool— pure filesystem check, no auto-download, no mesh walk, no networklist_available_robots()to use it, avoiding download attempts during status queriesTask 5: Remove dead dedup check (
utils.py)if user_cache not in pathswas alwaysTrue(paths starts empty) — removed dead checkcwd_assetsdedup (matters when CWD == assets dir)Tasks 1 & 4: Already done
SimWorlddocstring): Already present inmodels.pyfrom PR feat: simulation foundation — models, ABC, factory, model registry, assets #84 merge — verified[mujoco]ref): Already corrected to[sim-mujoco]in PR feat: MuJoCo simulation backend - AgentTool with 35 actions #85 — verified via grepTesting
Closes #105