Skip to content

Fix/2000 loader hardcoded color#2009

Open
akash-dabhi-qed wants to merge 2 commits intostrapi:mainfrom
akash-dabhi-qed:fix/2000-loader-hardcoded-color
Open

Fix/2000 loader hardcoded color#2009
akash-dabhi-qed wants to merge 2 commits intostrapi:mainfrom
akash-dabhi-qed:fix/2000-loader-hardcoded-color

Conversation

@akash-dabhi-qed
Copy link
Copy Markdown

What does it do?

Replaces the <img> tag in the Loader component with a <div> using a CSS mask, and drives the color from theme.colors.primary600 instead of a hardcoded hex value in the SVG.

Why is it needed?

The loader SVG had fill="#4945FF" hardcoded. Because it was loaded via an <img> tag, CSS could not override it — making the loader ignore custom themes and always render blue.

How to test it?

Open the Storybook Components -> Loader -> custom theme color story. The spinner renders in red, confirming it picks up the theme's primary600 value. With the old code it would still be purple.

Related issue(s)/PR(s)

Fixes #2000

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 13, 2026

@akash-dabhi-qed is attempting to deploy a commit to the Strapi Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 13, 2026

⚠️ No Changeset found

Latest commit: e35fc2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: loader component does not adapt to the primary color

1 participant