Skip to content

fix: guard against undefined theme size in Button for XS variant #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akash-dabhi-qed wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −7
Open

fix: guard against undefined theme size in Button for XS variant #2010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions packages/design-system/src/components/Button/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,19 +115,20 @@ const ButtonWrapper = styled<FlexComponent<'button'>>(Flex)<ButtonWrapperProps>`
${({ theme, $size }) => {
const sizeValue = theme.sizes.button[$size];

if (!sizeValue) return '';

if (typeof sizeValue === 'string') {
return `height: ${sizeValue};`;
}

const styles: string[] = [];
Object.entries(sizeValue).forEach(([breakpoint, breakpointValue]) => {
if (breakpointValue) {
if (breakpoint === 'initial') {
styles.push(`height: ${breakpointValue};`);
} else if (breakpoint in theme.breakpoints) {
const breakpointQuery = theme.breakpoints[breakpoint as keyof typeof theme.breakpoints];
styles.push(`${breakpointQuery} { height: ${breakpointValue}; }`);
}
if (!breakpointValue) return;
if (breakpoint === 'initial') {
styles.push(`height: ${breakpointValue};`);
} else if (breakpoint in theme.breakpoints) {
const breakpointQuery = theme.breakpoints[breakpoint as keyof typeof theme.breakpoints];
styles.push(`${breakpointQuery} { height: ${breakpointValue}; }`);
}
});

Expand Down