fix: correct orchestrator PDB conditional logic#41
Merged
wfernandes merged 2 commits intomainfrom Apr 30, 2026
Merged
Conversation
The conditional combined the autoscaling and replicaCount branches with `and` instead of `or`, requiring `autoscaling.enabled` to be both true and false simultaneously. As a result, the PodDisruptionBudget never rendered regardless of values. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gramidt
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The conditional in
charts/orchestrator/templates/pdb.yamlcombined the autoscaling and replicaCount branches withandinstead ofor, requiringautoscaling.enabledto be simultaneouslytrueandfalse. As a result, thePodDisruptionBudgetresource never rendered regardless of values.Before:
After:
Testing
helm lint charts/orchestratorpasses. Verifiedhelm templateoutput across all relevant cases:pdb.enabled=true,autoscaling.enabled=true,minReplicas=2→ PDB renderspdb.enabled=true,autoscaling.enabled=true,minReplicas=1→ PDB skippedpdb.enabled=true,autoscaling.enabled=false,replicaCount=2→ PDB renderspdb.enabled=false→ PDB skippedDocumentation
N/A — bug fix only; no behavior or values surface changes.
Issue
https://maverics.atlassian.net/browse/BIGLIST-1347