Fix railgun unshield change note recovery#6397
Open
kjameslubin wants to merge 1 commit intodevelopfrom
Open
Conversation
…overy Partial unshields (spending less than the full note) create a change note that goes back to the sender. Previously, the change note's ciphertext was all zeros (dummy), making it impossible for the wallet scanner to decrypt and recover the change balance -- effectively burning the change. This fix: - Replaces dummy ciphertext with real AES-CTR encrypted ciphertext using the sender's viewing key (via createCommitmentCiphertext from Transfer.hs) - Uses the original note's random so npk verification passes in the scanner (npk == poseidon(masterPubKey, random)) - Passes ciphertext as parameter to createUnshieldRequest instead of hardcoding dummyCommitmentCiphertext Also fixes Dockerfile.multi libleveldb symlink to work on ARM64 (was hardcoded to x86_64 path). Tested on helium testnet: shield 50 -> unshield 25 -> 24.875 change note recovered successfully by the balance scanner. Made-with: Cursor
dustinnorwood
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npk == poseidon(masterPubKey, random)verification passes in the scannerTest plan
Tested end-to-end on helium testnet (local node):
Made with Cursor