Fix spurious tip changed detection #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken by stratum-mining#58 resulting in spurious "Tip changed" messages. Worse however is that that this caused m_last_block_time to update too often. When -sv2interval is set to 10 seconds or less, this results in PruneBlockTemplateCache never running.
Collaborator
Author
Before this PR the "Prune stale template" didn't show, though this bug only shows up if you set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by #58 resulting in spurious "Tip changed" messages.
Worse however is that that this caused
m_last_block_timeto update too often. When-sv2intervalis set to 10 seconds or less, this results inPruneBlockTemplateCachenever running.