PHP Notice: Only variables should be passed by reference in...#57
Open
ner00 wants to merge 3 commits intostremlau:masterfrom
Open
PHP Notice: Only variables should be passed by reference in...#57ner00 wants to merge 3 commits intostremlau:masterfrom
ner00 wants to merge 3 commits intostremlau:masterfrom
Conversation
The array_pop() function's parameter is passed 'by reference', meaning the function directly modifies the variable that is passed into the function (https://github.com/stremlau/html5_notifier/blob/5d85947e16ea9cac4544c59666fe0ff13ba2a44a/html5_notifier.php#L59). Due to this behaviour, you can't pass a function directly into array_pop(), you have to store the output of explode() into a variable first, then pass that variable into array_pop(). source: https://stackoverflow.com/a/45109918/924855
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
array_pop()function's parameter is passed "by reference", meaning the function directly modifies the variable that is passed into the functionhtml5_notifier/html5_notifier.php
Line 59 in 5d85947
Due to this behaviour, you can't pass a function directly into
array_pop(), you have to store the output ofexplode()into a variable first, then pass that variable intoarray_pop().source: https://stackoverflow.com/a/45109918/924855
Note: also replaced indentation tabs with spaces, it was a mix of both.