#175: Initial commit to create respective SpecObjectAttribute's to confirm that integration tests fail #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…firm that integration tests fail
torsknod2
changed the title
stanislaw
reviewed
Feb 18, 2025
| attribute_type=SpecObjectAttributeType.STRING, | ||
| definition_ref=ExampleIdentifiers.SPEC_ATTRIBUTE_IDs[0], | ||
| value="System ABC shall do XYQ.", | ||
| ), |
There was a problem hiding this comment.
Thanks for showing it with a test. This could be a useful change for the use case that you described.
Let's also add a validation inside the init method: if an int value is provided than the type should be INTEGER and similar for all other types. If these is a type mismatch, let's through a TypeError.
stanislaw
reviewed
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.