Skip to content

Crash in dev mode only on accepted generation #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shubhamugare merged 1 commit into from
Mar 28, 2025
Merged

Crash in dev mode only on accepted generation #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions syncode/grammar_mask/grammar_constrainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,13 @@ def _parse_partial_code(self, idx: int, partial_code: str, remainder_bytes: byte

self._update_valid_state(partial_code, idx, res)
except Exception as e:
if self.dev_mode == True:
if self.dev_mode == True and accepted_generation:
raise e
elif self.parse_failed == False and accepted_generation:
self.parse_failed = True
print("-"*50)
print(f"Parsing failed! Falling back to unconstrained decoding.\nException: {e}\nPartial code: {partial_code}\nParsed lexical tokens: {self.inc_parser.parsed_lexer_tokens}")
print("-"*50)
logger.info("-"*50)
logger.info(f"Parsing failed! Falling back to unconstrained decoding.\nException: {e}\nPartial code: {partial_code}\nParsed lexical tokens: {self.inc_parser.parsed_lexer_tokens}")
logger.info("-"*50)
skip = True
return res, skip

Expand Down