Adding SPH velocity evaluation #106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spossann
approved these changes
Nov 6, 2025
spossann
previously approved these changes
Nov 6, 2025
max-models
reviewed
Nov 7, 2025
|
|
||
| if n_xyz is None: | ||
| n_xyz = lambda x, y, z: 0.0 * x | ||
| n_xyz = lambda x, y, z: 1.0 + 0.0 * x |
Member
There was a problem hiding this comment.
Suggested change
| n_xyz = lambda x, y, z: 1.0 + 0.0 * x | |
| n_xyz = lambda x, y, z: np.ones_like(x, dtype=float) |
|
|
||
| if p_xyz is None: | ||
| p_xyz = lambda x, y, z: 0.0 * x | ||
| p_xyz = lambda x, y, z: 1.0 + 0.0 * x |
Member
There was a problem hiding this comment.
Suggested change
| p_xyz = lambda x, y, z: 1.0 + 0.0 * x | |
| p_xyz = lambda x, y, z: np.ones_like(x, dtype=float) |
Member
|
Hi @aminrai2000, could you please add the requested changes, push and then request review from me? There should not be any conflicts. |
Author
Hi Stefan. |
spossann
requested changes
Nov 13, 2025
src/struphy/pic/tests/test_sph.py
Outdated
Comment on lines
1119
to
1138
| def u_eta(eta1, eta2, eta3): | ||
| u1 = 1 / Lx * xp.cos(2 * xp.pi * l1 / Lx + 2 * xp.pi * eta1) * xp.cos(2 * xp.pi * eta2 + 2 * xp.pi * l2 / Ly) | ||
| u2 = 1 / Ly * xp.cos(2 * xp.pi * l1 / Lx + 2 * xp.pi * eta1) * xp.cos(2 * xp.pi * eta2 + +2 * xp.pi * l2 / Ly) | ||
| u3 = 0.0 * z | ||
| return (u1, u2, u3) | ||
|
|
||
| # derivatives: | ||
| # derivative == 1 -> ∂/∂e1 | ||
| # derivative == 2 -> ∂/∂e2 | ||
| def du_dx(x, y, z): | ||
| dux = -2 * xp.pi / Lx * xp.sin(2 * xp.pi / Lx * x) * xp.cos(2 * xp.pi / Ly * y) | ||
| duy = -2 * xp.pi / Lx * xp.sin(2 * xp.pi / Lx * x) * xp.cos(2 * xp.pi / Ly * y) | ||
| duz = 0.0 * z | ||
| return (dux, duy, duz) | ||
|
|
||
| def du_dy(x, y, z): | ||
| dux = -2 * xp.pi / Ly * xp.cos(2 * xp.pi / Lx * x) * xp.sin(2 * xp.pi / Ly * y) | ||
| duy = -2 * xp.pi / Ly * xp.cos(2 * xp.pi / Lx * x) * xp.sin(2 * xp.pi / Ly * y) | ||
| duz = 0.0 * z | ||
| return (dux, duy, duz) |
src/struphy/pic/tests/test_sph.py
Outdated
Comment on lines
1257
to
1258
| v1_e, v2_e, v3_e = du_deta1(ee1, ee2, ee3) | ||
| v1, v2, v3 = v_log |
Member
There was a problem hiding this comment.
This must be removed, as it is already done above. If you overwrite here, the Allreduce will not be performed and the mpi tests will fail.
src/struphy/pic/tests/test_sph.py
Outdated
Comment on lines
1263
to
1264
| v1_e, v2_e, v3_e = du_deta2(ee1, ee2, ee3) | ||
| v1, v2, v3 = v_log |
Member
There was a problem hiding this comment.
This must also be removed, as above
src/struphy/pic/tests/test_sph.py
Outdated
Comment on lines
1336
to
1340
| assert err_ux < 0.8709 | ||
| assert err_uy < 0.8709 | ||
| else: | ||
| assert err_ux < 0.716 | ||
| assert err_uy < 0.716 |
Member
There was a problem hiding this comment.
We must choose test parameters such that these error get at least below 0.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the following issue(s):
None
Core changes:
Model-specific changes:
None
Documentation changes:
None