Absolute K indexing fix: memlet volumn when mixed with cartesian#4
Merged
FlorianDeconinck merged 2 commits intostubbiali:physicsfrom May 28, 2025
Conversation
…xing is present in the vertical loop
romanc
approved these changes
May 28, 2025
Collaborator
romanc
left a comment
There was a problem hiding this comment.
I think this is fine as a workaround for this branch. If there's an easy test-case, we could take that and add it to the (mainstream) gt4py/cartesian testcases. That would make sure of "it'll go away (tm) in the new bridge".
Collaborator
Author
|
I have the goods, I'll put in a test case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per inline comment:
Today, we are looking at cases where absolute read and cartesian writes live in the same vertical loop e.g.
This code is valid, the issue with DaCe bridge is that the volume given to the memlet differs in this case:
Since those apply to the same underlying array, DaCe is not too happy about it. The workaround is to use the "variable K offset" pipeline for the cartesian to match the wider volume and at the same time keep the relative index correct.