WIP: Re #5 - Parameter schema + refactor for Unit and Value schemas#8
Open
marshallmcdonnell wants to merge 25 commits intostuchalk:mainfrom
Open
WIP: Re #5 - Parameter schema + refactor for Unit and Value schemas#8marshallmcdonnell wants to merge 25 commits intostuchalk:mainfrom
marshallmcdonnell wants to merge 25 commits intostuchalk:mainfrom
Conversation
This was referenced Jun 17, 2019
Closed
20fe9a1 to
dcfc579
Compare
Contributor
Author
|
@stuchalk So this one should be ready except needs MR #7 approved and merged first (will rebase this feature off those changes going in) This one re-writes the Unit and Value schema based on the need that arose with Parameter schema setup (and only realizing that by creating the tests 😁) Pretty happy though, it is checking for valid schema in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work includes:
parameterschemaunitandvalueschemascontext->unit->value->parameter) that arose with creating theparameterschema. Needed scripting withjsonschemapackage, not just CLIexamples/sectionsas well as invalidating "bad" schema found in the tests themselves such as bad values and additional properties that shouldn't be there.Blocked by: MR #7 needs to be merged first so we can rebase off that work