This repository was archived by the owner on Jan 14, 2020. It is now read-only.
Disable all flake8 checks not indicating errors#26
Open
walles wants to merge 1 commit intostuffmatic:masterfrom
Open
Disable all flake8 checks not indicating errors#26walles wants to merge 1 commit intostuffmatic:masterfrom
walles wants to merge 1 commit intostuffmatic:masterfrom
Conversation
With this change in place, here's what I get from flake8. Especially the warningas about accessing undefined variables are suspicious: ``` src/blam.py:38:1: F811 redefinition of unused 'math' from line 20 src/blam.py:249:42: F812 list comprehension redefines 'r' from line 246 src/blam.py:375:5: F841 local variable 'cIn' is assigned to but never used src/blam.py:696:13: F841 local variable 'f' is assigned to but never used src/blam.py:943:9: F841 local variable 'Qba' is assigned to but never used src/blam.py:947:9: F841 local variable 'Qca' is assigned to but never used src/blam.py:948:9: F841 local variable 'Qcb' is assigned to but never used src/blam.py:1145:9: F841 local variable 'k1' is assigned to but never used src/blam.py:1146:9: F841 local variable 'firstFace' is assigned to but never used src/blam.py:1210:32: F821 undefined name 'f10Idx' src/blam.py:1224:32: F821 undefined name 'f10dx' src/blam.py:1435:9: F841 local variable 'scn' is assigned to but never used src/blam.py:1611:9: F841 local variable 'FuFv' is assigned to but never used ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change in place, here's what I get from flake8. Especially the
warningas about accessing undefined variables are suspicious: